Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard 12.0.1 uses eslint version 5.4.0 when 5.6.0 is specified in the package.json #1256

Closed
7373Lacym opened this issue Mar 13, 2019 · 8 comments

Comments

@7373Lacym
Copy link

commented Mar 13, 2019

What version of standard?
12.0.1
What operating system, Node.js, and npm version?
System Version: macOS 10.13.6 (17G4015)
Kernel Version: Darwin 17.7.0
npm Version: 6.5
node Version: v11.8.0
What did you expect to happen?
Installing standard as a dev dependency in an empty project would use eslint 5.6
What actually happened?
Installing standard as a dev dependency in an empty project would use eslint 5.4
Here is my package.json

{
  "name": "test-project",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "devDependencies": {
    "standard": "^12.0.1"
  }
}

Running npm ls eslint yields

test-project@1.0.0 ~/test-project
└─┬ standard@12.0.1
  └── eslint@5.4.0

Eslint 5.4.0 does not play well with create-react-app. Might be related or the same thing as #1249

@LinusU

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

It's bumped to 5.6.0 in master, but not released yet.

@feross would you mind releasing a 12.0.2 release to fix the problems with create-react-app?

also, is there a reason eslint is pinned with ~ intead of ^? 🤔

@7373Lacym

This comment has been minimized.

Copy link
Author

commented Mar 13, 2019

Ahhh okay. Sorry for the misunderstanding.

@ovhemert

This comment has been minimized.

Copy link

commented Apr 12, 2019

I would also like to see the new version published. It seems to resolve a high severity vulnerability also.

standard@12.0.1 › eslint@5.4.0 › js-yaml@3.13.0

You can see it here on Snyk.

cc: @LinusU @feross

@LinusU

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

unfortunately, I don't have access to releasing new versions, ping @feross

actually, I do 😁

Okay, I'll set up a release proposal PR and give the other maintainers some time to weigh in

@ovhemert

This comment has been minimized.

Copy link

commented Apr 12, 2019

Would be great.. Thanks 👍🏻

@LinusU

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

#1270 🚀

@stale

This comment has been minimized.

Copy link

commented Jul 11, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jul 11, 2019

@feross

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

Standard 13 is released which uses ESLint 6 🚀So, I'll close this issue now.

@feross feross closed this Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.