Switch eslint dependency to 5.x

[LinusU]

I think we should change the eslint dependency to ^5.0.0 in our package.json dependencies. This way we'll be compatible whenever our users is using standard together with any other package that places restrictions on the eslint version (i.e. react-scripts). See #1270, #1210, #1256 for some previous discussion

It will also allow people to upgrade to the latest eslint version without waiting on us to release a new version.

Happy to hear of any potential downsides, any thoughts? ☺️

[GaryGSC]

ESLint specifically recommends against it.
Using ^ instead of ~ is likely to break CI builds.

[LinusU]

Ah, hmm, that's unfortunate 😞

[GaryGSC]

Yeah. 😕

In other news, eslint@6 is almost out. They cut a release candidate the other day.

[GaryGSC]

And by that I mean:

1. It's time to start looking into version 6. Among other things, it drops support for Node 6 and changes a handful of rules, so that'd definitely represent a major version bump for standard.
2. Unless there are critical security fixes, eslint@~5.16 is looking to be the final version of eslint@^5. I think you could get a lot of the wins you're hoping for by releasing a version that uses ~5.16.

[feross]

In the past, we stopped using ^ because new minor versions would introduce cause subtle rule changes that would cause builds to start failing.

[feross]

@LinusU If we just kept up to date with the latest eslint releases better, would this issue be considered resolved?

[GaryGSC]

At least from my point of view, yes.

[feross]

@GaryGSC Okay, that I can do.

[feross]

Closing this issue. We'll just keep ESLint up-to-date more proactively in the future.