Skip to content

/standard

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow when 'node_modules' contains symlinked folders #130

Closed
feross opened this issue May 10, 2015 · 2 comments

Comments

@feross
Copy link
Member

commented May 10, 2015 

$ time standard
standard  0.67s user 0.06s system 108% cpu 0.673 total

$ time standard
standard  22.24s user 7.28s system 111% cpu 26.459 total

I have a deeply symlinked node_modules folder (constructed using zelda), and it's killing performance of standard. Symlinks shouldn't have this much of an effect. Is there a param we can pass to glob? Or are OS X symlinks just slow?
@feross

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented May 10, 2015

It's worth noting that node_modules is being ignored (per the defaults), yet the slowdown still occurs.

@feross feross added bug help wanted labels May 13, 2015

@feross feross referenced this issue May 25, 2015
Closed
@feross

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented May 25, 2015

Turns out this innocent change in v3.7.0 was the root cause: 04fe0ef

By reverting this change, standard is now 12.6x faster to run! (1.79s vs 22.59s over the webtorrent codebase)

Published as 3.11.1.

@feross feross closed this May 25, 2015

@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug help wanted
Milestone
No milestone
1 participant
@feross
You can’t perform that action at this time.