Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release proposal: standard v13 #1318

Closed
feross opened this issue Jul 6, 2019 · 12 comments

Comments

@feross
Copy link
Member

commented Jul 6, 2019

Planned release date: July 8

Please give feedback! Run npx standard@next or npm install standard@next to try it out.

When you upgrade, consider running standard --fix to automatically format your code to match the newly added rules.

New features

  • Update eslint from ~5.16.0 to ~6.0.1

    • BREAKING: Node.js 6 is no longer supported
      • Node.js 6 is EOL and will no longer be receiving security updates. As a result, the eslint team has decided to drop support for it.
      • To prevent breaking CI for projects which still support Node 6, standard silently passes when run by an unsupported version of Node.
    • For eslint-config-standard users only: Plugins are no longer affected by eslint's location
      • Previously, ESLint loaded plugins relative to the location of the ESLint package itself. As a result, we suggested that users with global ESLint installations should also install plugins globally, and users with local ESLint installations should install plugins locally.
      • With ESLint v6, plugins should always be installed locally, even if ESLint was installed globally. More precisely, ESLint v6 resolves plugins relative to the end user’s project by default, and always resolves shareable configs and parsers relative to the location of the config file that imports them.
      • See migrating to ESLint 6.0.0 for more information.
  • Update eslint-plugin-promise from ~4.0.0 to ~4.2.1

    • No significant changes
  • Update eslint-plugin-node from ~7.0.1 to ~9.1.0

    • No significant changes
  • The README is now available in Japanese 🇯🇵!

    • Thanks to @Munieru for the excellent work!
    • Other community contributed translations exist in Spanish, French, Italian, Korean, Portuguese, Simplified Chinese, and Taiwanese Mandarin. More translations are welcome.

New rules

(Estimated % of affected standard users, based on test suite in parens)

@feross feross added the meta label Jul 6, 2019

@feross feross added this to the standard v13 milestone Jul 6, 2019

@feross feross self-assigned this Jul 6, 2019

@mightyiam

This comment has been minimized.

Copy link
Contributor

commented Jul 6, 2019

Lovely to see progress! Thank you for your service to the community, @feross! 💓

@feross

This comment has been minimized.

Copy link
Member Author

commented Jul 6, 2019

You're welcome, @mightyiam.

@voxpelli

This comment has been minimized.

Copy link

commented Jul 6, 2019

Lovely with a new release! Would it be possible to still get https://github.com/standard/eslint-config-standard/issues/129 in there?

@voxpelli

This comment has been minimized.

Copy link

commented Jul 6, 2019

This one would also be neat: standard/eslint-config-standard#136

@feross

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

(I removed the #1314 rule because of false positive reports.)

standard 13.0.0 is released now!

@feross feross closed this Jul 11, 2019

@fanatid

This comment has been minimized.

Copy link

commented Jul 11, 2019

@feross thank you for release! @Flet can you release new version of semistandard?

@jprichardson

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

Thanks @feross!

@Flet if you are able to release a new https://github.com/Flet/semistandard we'd be grateful. We could then get all devDeps in indutny/bn.js#220 in one clean and tidy PR 😜

@feross

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

@Flet Lmk if you want me to publish the new semistandard. I don't think I have publish permission on the various packages, e.g. eslint-config-semistandard, so I can't do it.

Related, I think we should make an org so it is easier to manage npm permissions: #1324

@Flet

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

Yeah @feross, time to move it to the standard org I think :)

@feross

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

@Flet Sure, if you want to transfer the semistandard repo here, it might be easier to keep an eye on it. Up to you :)

I do think that an npm org would make it easier to manage the npm permissions at least.

@fanatid

This comment has been minimized.

Copy link

commented Jul 14, 2019

@feross can you show how I can measure ecosystem impact for new rules? (like you done for new rules here)
Would like to check arrow-parens for always.

@feross

This comment has been minimized.

Copy link
Member Author

commented Jul 31, 2019

can you show how I can measure ecosystem impact for new rules?

You run the test suite and then take the number of failing tests divided by the total number of tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.