Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract standard config as a an eslint shareable config module #132

Closed
Flet opened this issue May 10, 2015 · 10 comments

Comments

@Flet
Copy link
Member

commented May 10, 2015

http://eslint.org/docs/developer-guide/shareable-configs

This would also allow a level of versioning specific to the rules themselves

@julien-f

This comment has been minimized.

Copy link

commented May 12, 2015

It seems like a good idea.

@AlexKVal

This comment has been minimized.

Copy link

commented May 12, 2015

👍

@feross

This comment has been minimized.

Copy link
Member

commented May 13, 2015

Okay, this is published here: https://github.com/feross/eslint-config-standard

@feross

This comment has been minimized.

Copy link
Member

commented May 13, 2015

And eslint-config-standard on npm.

@feross

This comment has been minimized.

Copy link
Member

commented May 13, 2015

standard should depend on eslint-config-standard so we can keep the rules in just one place. That's done on the shareable-config branch, but it doesn't work because of this eslint bug (eslint/eslint#2487). Once that's fixed, we can release that branch.

@feross

This comment has been minimized.

Copy link
Member

commented May 13, 2015

Also, I just added all current collaborators to the eslint-config-standard repo.

@feross

This comment has been minimized.

Copy link
Member

commented May 15, 2015

I just merged the shareable-config branch into master and published standard 3.9.0.

standard now depends on eslint-config-standard. If you want to fork standard, you should extend it instead using eslint's shareable configs.

@Flet care to try that with semistandard? Let's see if it works as expected.

@feross feross closed this May 15, 2015

@Flet

This comment has been minimized.

Copy link
Member Author

commented May 20, 2015

FYI, semistandard now uses eslint-config-semistandard which extends eslint-config-standard,

This is incredibly awesome now:

  • semistandard should automagically get all non-breaking standard changes on every install.
  • eslint-config-semistandard clearly shows only the rules that are mutated from standard (The One Rule).
  • if others are considering forking standard, I highly recommend looking at semistandard as an example! :)
@dcousens

This comment has been minimized.

Copy link
Member

commented May 21, 2015

Cheers @Flet, this is very cool indeed.

@feross

This comment has been minimized.

Copy link
Member

commented May 22, 2015

Nice @Flet!

@feross feross added enhancement and removed enhancement labels May 10, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
You can’t perform that action at this time.