Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shareable configs should depend directly on plugins #1331

Closed
feross opened this issue Jul 12, 2019 · 1 comment

Comments

@feross
Copy link
Member

commented Jul 12, 2019

Due to the eslint 6 changes in how plugins are detected, I think we can now make eslint-config-standard and eslint-config-standard-jsx depend directly upon the various plugins that they use instead of making them peerDependencies as we do now.

This would be a nice change because then standard can drop it's direct dependency on these and then the entire configuration is determined by the versions of the configs we depend on instead of the current situation where it's the versions of the configs + the versions of the plugins together.

@feross feross added the meta label Jul 12, 2019

@feross feross added this to the standard v14 milestone Jul 12, 2019

@feross

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

Duplicate of #1345

@feross feross marked this as a duplicate of #1345 Aug 14, 2019

@feross feross closed this Aug 14, 2019

@feross feross removed this from the standard 14 milestone Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.