Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of standard on "Try It Out" page #1332

Closed
feross opened this issue Jul 12, 2019 · 3 comments

Comments

@feross
Copy link
Member

commented Jul 12, 2019

Hey @Flet! The demo page hits a remote service to make code standard, is that right?

How do we update it? It's currently running standard v10 it seems:

standardizer@2.0.0, standard@10.0.3, eslint@3.19.0, eslint-config-standard@10.2.1, eslint-config-standard-jsx@4.0.2, eslint-plugin-import@2.2.0, eslint-plugin-node@4.2.3, eslint-plugin-promise@3.5.0, eslint-plugin-react@6.10.3, eslint-plugin-standard@3.0.1, standard-engine@7.0.0

@feross feross changed the title Update version of standard being used Update version of standard on "Try It Out" page Jul 12, 2019

@feross feross transferred this issue from standard/standard-demo Jul 12, 2019

@Flet

This comment has been minimized.

Copy link
Member

commented Jul 13, 2019

Oh! Yeah that is on Glitch.I'll updated it

@Flet

This comment has been minimized.

Copy link
Member

commented Jul 13, 2019

Fixed! Can you verify?

I'll pass along a Glitch project invite in a private channel @feross. Totally fine if we want to move away from this external service as well.

I recall having problems browserifying the eslint project way back, so this was a path of less resistance. Perhaps we would have more luck with eslint today. A version of standard that runs 100% client side would be pretty neat! :)

@feross

This comment has been minimized.

Copy link
Member Author

commented Jul 13, 2019

Fixed! Can you verify?

Looks like it's working now! Thanks for the quick fix.

I'll pass along a Glitch project invite in a private channel @feross. Totally fine if we want to move away from this external service as well.

I didn't realize this was deployed on Glitch. Nor that Glitch could do server-side stuff. Really neat!

A version of standard that runs 100% client side would be pretty neat! :)

Agreed!

@feross feross closed this Jul 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.