Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shareable config easier to use #1345

Closed
feross opened this issue Jul 31, 2019 · 2 comments

Comments

@feross
Copy link
Member

commented Jul 31, 2019

It would be great if there's some way to avoid having folks need to install 5-6 packages when they're using eslint-config-standard directly.

See:

@feross

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

It doesn't seem possible to make things simpler. The instructions say:

If your shareable config depends on a plugin, you should also specify it as a peerDependency (plugins will be loaded relative to the end user’s project, so the end user is required to install the plugins they need). However, if your shareable config depends on a third-party parser or another shareable config, you can specify these packages as dependencies.

We only depend on plugins in eslint-config-standard and eslint-config-standard-jsx, so these must be peer dependencies. We don't depend on other configs or a custom parser (yet).

@feross feross closed this Aug 14, 2019

@mightyiam

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

That's right. Here's the upstream issue to track:
eslint/eslint#3458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.