Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require JSX event handler names to follow conventions (react/jsx-handler-names) #1371

Closed
feross opened this issue Aug 15, 2019 · 1 comment

Comments

@feross
Copy link
Member

commented Aug 15, 2019

https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-handler-names.md

Ensures that any component or prop methods used to handle events are correctly prefixed.

Rule Details

The following patterns are considered warnings:

<MyComponent handleChange={this.handleChange} />
<MyComponent onChange={this.componentChanged} />

The following patterns are not considered warnings:

<MyComponent onChange={this.handleChange} />
<MyComponent onChange={this.props.onFoo} />

Here's an example of the diff that I applied to bitmidi.com in order to comply with this rule: feross/bitmidi.com@67ed076

@feross

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

Shipping in standard 14.

@feross feross closed this in 5dfdc83 Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.