Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow spaces inside of curly braces in JSX expressions in children (react/jsx-curly-spacing) #1373

Closed
feross opened this issue Aug 15, 2019 · 1 comment

Comments

@feross
Copy link
Member

commented Aug 15, 2019

https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-curly-spacing.md

We already require no spaces inside of JSX expression in attributes, i.e. <Hello name={firstname} /> instead of <Hello name={ firstname } />.

I want to enforce the same rule for JSX expressions in children.

Before:

    "react/jsx-curly-spacing": ["error", "never"],

After:

    "react/jsx-curly-spacing": ["error", {
      "attributes": { "when": "never" },
      "children": { "when": "never" },
      "allowMultiline": true
    }],

The following patterns are considered warnings:

<Hello name={ firstname } />;
<Hello name={ firstname} />;
<Hello name={firstname } />;
<Hello>{ firstname }</Hello>;

The following patterns are not warnings:

<Hello name={firstname} />;
<Hello name={{ firstname: 'John', lastname: 'Doe' }} />;
<Hello name={
  firstname
} />;
<Hello>{firstname}</Hello>;
<Hello>{
  firstname
}</Hello>;

@feross feross added this to the standard 14 milestone Aug 15, 2019

@feross

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

Shipping in standard 14.

@feross feross closed this in c1ebec6 Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.