v14 --fix rewrites `a 'b' c` to 'a \'b\' c' instead of "a 'b' c"

[wmhilton]

What version of this package are you using?
v14.0.0

What operating system, Node.js, and npm version?
node v10.15.3

What happened?
standard --fix rewrote my template strings (containing single quotes) into single quote strings (containing escaped single quotes):

e.g.

-    expect(await fs.exists(`${dir}/a.txt`)).toBe(true, `'a.txt' exists`)
+    expect(await fs.exists(`${dir}/a.txt`)).toBe(true, '\'a.txt\' exists')

What did you expect to happen?
I didn't expect that. Like... I'm a little sad that it rewrote my template strings at all, but short of reverting #838, at worst --fix should rewrite them using double quotes like,

+    expect(await fs.exists(`${dir}/a.txt`)).toBe(true, "'a.txt' exists")

Are you willing to submit a pull request to fix this bug?
Maybe? If someone can point me at what file does the --fix behavior shouldn't be too hard for me to figure out.

[feross]

I agree with you that this fix is not ideal. Double quotes would be better. The fix for this would need to go into ESLint in this file: https://github.com/eslint/eslint/blob/master/lib/rules/quotes.js It looks like we'd need to take into account the value of the avoidEscape rule setting whenever converting between quote types in --fix. This seems like a reasonable change.

@wmhilton As a next step, would you like to open this as an issue on ESLint to see what they think of the idea?

[wmhilton]

As a next step, would you like to open this as an issue on ESLint to see what they think of the idea?

done

[feross]

Cool, let's wait to see how that issue discussion goes: eslint/eslint#12129

[feross]

@wmhilton FYI, there's a new issue opened with a proposed solution to this and other problems with the quotes rule: eslint/eslint#12156