Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standard does not respect .gitignore #1386

Closed
edosrecki opened this issue Aug 23, 2019 · 2 comments

Comments

@edosrecki
Copy link

commented Aug 23, 2019

What version of this package are you using?
14.0.2

What operating system, Node.js, and npm version?
macOS v10.13.6
Node.js v10.16.3
npm v6.9.0

What happened?
standard processes files and directories which are specified in .gitignore.

After upgrading from v13.1.0 to v14.0.x, standard command starts failing since it processes the dist/ directory which is listed in .gitignore. Behaviour is same not only for directories, but also for files specified in .gitignore.

Ignoring the files/directories in package.json fixes the issue.

What did you expect to happen?
standard should ignore files and directories specified in .gitignore.

Are you willing to submit a pull request to fix this bug?
Perhaps. :)

@feross

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

You're right. I just confirmed this is a bug.

@feross

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

This is fixed in deglob 4.0.1. If you reinstall standard (and potentially your package-lock.json file), this should be fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.