Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linebreaks on Windows (CRLF vs. LF) #140

Closed
timdp opened this issue May 18, 2015 · 2 comments

Comments

@timdp
Copy link

commented May 18, 2015

Let me start by saying I'm all for avoiding bikeshedding and finally agreeing on a clean style for JS. As soon as I discovered the standard, I started pushing it here at work.

That being said, we're primarily a Windows company and I was kind of disappointed when Atom's Standard linter started complaining about the fact that I use CRLF rather than LF. I'd happily switch to LF if it wouldn't cause issues with some apps (which I didn't write, so this is just a statement of fact).

Since I basically push all my stuff to a Git repository and Git silently handles line endings, personally, I don't worry about mixing CRLF and LF. I just use CRLF all over, since the platform actually expects me to.

I'd obviously like to avoid starting all my scripts with a preamble that makes the linter ignore CRLFs, especially since it won't affect people that pull in my code via Git. What are my options here?

I'm assuming that this issue pertains to JS Standard Style itself and not to the linter per se. Do correct me if I'm wrong. Thanks!

feross added a commit to standard/eslint-config-standard that referenced this issue May 18, 2015

@feross

This comment has been minimized.

Copy link
Member

commented May 18, 2015

@timdp Fair enough. I agree that most people are using Git and that automatically handles this. Released as 3.11.0.

@feross feross closed this May 18, 2015

@timdp

This comment has been minimized.

Copy link
Author

commented May 19, 2015

Cool, thanks!

@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
You can’t perform that action at this time.