Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose eslint's "checkstyle" output format through command line switch #142

Closed
lvillani opened this issue May 20, 2015 · 6 comments

Comments

@lvillani
Copy link
Contributor

commented May 20, 2015

eslint can print its output in Checkstyle format which is extremely useful to integrate standard with editors/IDEs, since parsing it is more robust than stylish' format.

Since standard is based on eslint it would be nice to expose this feature from standard's command line.

@lunaryorn

This comment has been minimized.

Copy link

commented May 20, 2015

👍

@feross

This comment has been minimized.

Copy link
Member

commented Jun 2, 2015

So far editors haven't had any issues integrating using the current format. A simple regex will do the trick. I'd prefer to keep the number of command line flags in this module to the bare minimum so I'm going to close this. If this actually blocks an editor from adding support, I'm happy to reconsider. :)

@feross feross closed this Jun 2, 2015

@dcousens

This comment has been minimized.

Copy link
Member

commented Jun 2, 2015

@lvillani did you have an editor in mind where this would make your life easier? (I assume you might be looking to writing a plugin maybe?)

@lvillani

This comment has been minimized.

Copy link
Contributor Author

commented Jun 2, 2015

@dcousens I opened the bug report based on a request from @lunaryorn but then proceeded to implement a pattern recogniser. I'm not sure whether this change is still needed, though.

@lunaryorn

This comment has been minimized.

Copy link

commented Jun 2, 2015

@feross How can you reasonably claim that there were no issues with integrating the current format in editors? You didn't write all these integrations, did you? How do you know what issues actually occurred? And what is this issue, if not an issue with “integrating the current format in editors”?

I maintain Flycheck, which supports about 70 tools for various languages. For you, it's just a “simple regex”. For me, it's about 50 different regexps, which I have to understand and maintain, and constantly fix, because writing linters is apparently all about changing the output format with every new release to add just another pointless fancy new thingy.

One regexp is simple. 50 regexps are an incredibly brittle and a countless source of problems. Regexps just don't scale.

@feross

This comment has been minimized.

Copy link
Member

commented Jun 11, 2015

@lunaryorn I didn't write all the integrations, but I've read several of them. A regex as simple as this will do the trick :)

I understand that you don't want to maintain a bunch of changing regexes – that sounds painful. However, the output format of standard is locked – it will never change. So assuming the regex you wrote for standard is correct, it will never stop working and you will never need to change it.

@feross feross added enhancement and removed enhancement labels May 10, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
You can’t perform that action at this time.