Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed issues (standard 3.11.0) #144

Closed
gr2m opened this issue May 24, 2015 · 2 comments

Comments

@gr2m
Copy link

commented May 24, 2015

Here's a simple change in our code that brings down standard execution time down from 16s to 1s. hoodiehq/pouchdb-hoodie-api@3aefb7c

Instead of ignoring the dist/ and docs/ folders, we instead pass the blobs for files we want to be checked. Both should have the same effect, but the difference in time execution is 1600%. Any idea what could cause this? Are we doing it wrong™️ ?

@feross

This comment has been minimized.

Copy link
Member

commented May 25, 2015

Yeah, I noticed this slowdown before too. See issue: #130

Your opening this issue prompted me to finally run git bisect and figure this out. Turns out this innocent change in v3.7.0 was the root cause: 04fe0ef

By reverting this change, standard is now 12.6x faster to run! (1.79s vs 22.59s over the webtorrent codebase)

Published as 3.11.1.

@feross feross closed this May 25, 2015

@gr2m

This comment has been minimized.

Copy link
Author

commented May 25, 2015

fuckyeah! That's fantastic news! Thanks Feross!!

btw, talking about "standards", I think you'll love https://www.npmjs.com/package/semantic-release very much. Once you start using it, you won't look back (just like standard form me :) ). Happy to help with the setup. And if you don't like it, drinks on me 🍻 🍸

gr2m added a commit to hoodiehq/pouchdb-hoodie-api that referenced this issue May 25, 2015

@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
You can’t perform that action at this time.