Global return error

[dcousens]

Despite globalReturn being true, I still get Illegal return statement when I use return in a self-contained translation unit (file/module).

return

Isn't this behaviour is meant to be allowed?

[feross]

Yes, this is meant to be allowed.

[feross]

I found the issue with git bisect. Bug in eslint. Issue reported: eslint/eslint#2636

I'm going to just remove support for ES6 modules until this is fixed, since it's marked "experimental" in eslint. If people really want ES6 modules, they can use a custom parser like babel-eslint (now supported).

[feross]

Hm, actually removing support for modules is likely to be more disruptive than just leaving this bug in there. It's been around since 3.0.0.

[feross]

Reverted in standard/eslint-config-standard@537fbbe

[dcousens]

I'm happy to wait for this to be fixed in eslint, this is an edge case to begin with anyway.

[feross]

@dcousens cool, sounds good

[feross]

ESLint says this is working as intended:

Modules can't be wrapped in function scope, so a global return isn't possible.

@dcousens Open to suggestions about how to proceed.

[dcousens]

@feross well if it isn't possible, I say we stay entirely agnostic and set globalReturn to false?

At least then it will be consistent across development environments (node, browserify or otherwise).

IMHO anyway.

[Cuel]

What if I in index.js wanted to do like this

return console.error('missing parameter')

As in I'd like to exit without throwing an error. It woudn't be allowed in standard?

[dcousens]

@Cuel more to the point, it isn't allowed in eslint, due to a broad definition of module AFAIK.

[feross]

@Cuel @dcousens I left a comment asking for more clever behavior from eslint here: eslint/eslint#2636 (comment) Feel free to support / share your opinion.

[dcousens]

@feross ES6 makes this difficult.

Perhaps we should just change globalReturn: false?
This is only going to become more annoying as time goes on, and that does seem to be the current behaviour so it isn't a breaking change.

[feross]

Agreed.