Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upPolicy for adding browser globals? #151
Comments
This comment has been minimized.
This comment has been minimized.
|
The browser globals are defined here. I'm not sure if there's a policy, but only a minimum amount of globals are exposed. I wouldn't expect |
This comment has been minimized.
This comment has been minimized.
|
Gotcha. I hadn't noticed, but yeah, none of the other browser globals are set. |
This comment has been minimized.
This comment has been minimized.
|
@cesarandreu AFAIK the policy is you should be using |
This comment has been minimized.
This comment has been minimized.
|
Yep, what @dcousens said. Especially for lowercase global variables like I've considered adding all the browser globals that begin with capital letters, but it hasn't been annoying enough for me yet (or seemingly anyone else). I just do |
This comment has been minimized.
This comment has been minimized.
|
I gave it some thought, I agree it's probably better since it's more explicit. |
This comment has been minimized.
This comment has been minimized.
|
Cool, I'm going to close this. |
cesarandreu commentedJun 8, 2015
What are your plans for handling new browser globals? Or rather, how far along does adoption have to be for a browser global to get added?
For example, Fetch API adds
window.fetch,window.Request,window.Response, andwindow.Headers.