Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable no-lone-block #163

Closed
julien-f opened this issue Jun 17, 2015 · 4 comments

Comments

@julien-f
Copy link

commented Jun 17, 2015

This rule has been disabled in #121 because it did not take into account ES6 block bindings.

As it has been fixed in eslint 0.23, I think it should be enabled again.

@Flet

This comment has been minimized.

Copy link
Member

commented Jun 17, 2015

We may want to wait until 0.24.0 as there is a bug in 0.23.0 that is causing some of the tests to fail (eslint/eslint#2764).

@Flet

This comment has been minimized.

Copy link
Member

commented Jun 17, 2015

...or at least 0.23.1 :)

@julien-f

This comment has been minimized.

Copy link
Author

commented Jun 17, 2015

Indeed :)

@feross

This comment has been minimized.

Copy link
Member

commented Jun 18, 2015

Agreed. I'll just re-enable the rule right away. We're already depending on a git commit hash for the eslint dependency, so I can just update the hash. As soon as 0.23.1 or 0.24.0 is released, we can switch back to the npm dep.

Released as 4.3.1.

@feross feross closed this Jun 18, 2015

@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.