Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem when using the full path when ignoring files #166

Closed
watson opened this issue Jun 18, 2015 · 1 comment

Comments

@watson
Copy link
Member

commented Jun 18, 2015

I have a folder named ~/code/node_modules in which I put the source code of all the modules I'm developing. But as of v4.0.0 it seems that standard will now use the full path of a file when choosing to ignore it or not (I think it was introduced by 6476721). And since my .gitignore is set up to ignore the folder node_modules, standard will now ignore all my files since the parent two levels up is also called node_modules.

I think it would be an easy fix to just use the relative path, but I'm not sure so I would like to hear your comments :)

@mafintosh mafintosh closed this in d10ab92 Jun 23, 2015

feross added a commit that referenced this issue Jun 23, 2015

Merge pull request #168 from feross/relative-gitignore
only use relative paths in ignore check. fixes #166
@feross

This comment has been minimized.

Copy link
Member

commented Jun 23, 2015

Thanks to @mafintosh, this is fixed! Released as 4.3.2.

Flet added a commit to Flet/standard that referenced this issue Oct 23, 2015

@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
You can’t perform that action at this time.