Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint: `no-useless-call` #184

Closed
mightyiam opened this issue Jul 13, 2015 · 5 comments

Comments

@mightyiam
Copy link
Contributor

commented Jul 13, 2015

@dcousens

This comment has been minimized.

Copy link
Member

commented Jul 13, 2015

This is great, for ES6.

In ES5 it would limit the user from using apply.

@dcousens dcousens added the question label Jul 13, 2015

@mightyiam

This comment has been minimized.

Copy link
Contributor Author

commented Jul 13, 2015

@dcousens it doens't prevent use of appply altogether. Only when it is better to use the () call syntax.

Do you see something that I do not?

@feross

This comment has been minimized.

Copy link
Member

commented Jul 13, 2015

@mightyiam Nice - this rule looks good to me, unless I'm missing something that @dcousens has caught. The new rule is in the master branch, so we have to wait for a release before we can add it.

@dcousens

This comment has been minimized.

Copy link
Member

commented Jul 14, 2015

Nevermind, I was mistaking the warnings for prefer-spread (seen in the commit posted above) to be relevant to this rule.

👍 lets put it in.

@feross

This comment has been minimized.

Copy link
Member

commented Jul 17, 2015

This will be fixed in eslint 1.0.0 and standard 5.0.0. #192

@feross feross closed this Jul 23, 2015

@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.