Skip to content

/standard

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phantomjs environment broken #194

Closed
LinusU opened this issue Jul 18, 2015 · 5 comments

Comments

@LinusU
Copy link
Member

commented Jul 18, 2015

For some reason a file like the following fails with "phantom" is not defined..

/* eslint-env phantomjs */

phantom.exit(0)
@LinusU LinusU referenced this issue Jul 18, 2015
Merged
@LinusU

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jul 18, 2015

The problem was in eslint, I proposed a fix over there...
@LinusU

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jul 18, 2015

Patch merged into master in eslint
@LinusU

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jul 20, 2015

@feross Could you add the blocked-on-eslint label on this bug please :)

@feross feross added bug blocked labels Jul 20, 2015

@feross

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jul 20, 2015

@LinusU Done! Thanks :)

For reference: eslint/eslint#3064
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jul 24, 2015

Fixed in eslint master :) standard will get the fix the next time we update eslint.

@feross feross closed this Jul 24, 2015

@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocked bug
Milestone
No milestone
2 participants
@LinusU @feross
You can’t perform that action at this time.