Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`no-throw-literal` warning not shown on concatenated exception messages #198

Closed
taromero opened this issue Jul 20, 2015 · 2 comments

Comments

@taromero
Copy link

commented Jul 20, 2015

throw 'a' + 'b' doesn't show the no-throw-literal warning, as I would expect.

throw 'a' (no string concatenation) does show the warning.

This is probably an issue of the underlying linters that standard uses (in which case please close this ticket), but I'm rising the flag just in case.

taromero added a commit to taromero/latte that referenced this issue Jul 20, 2015

Avoid throwing string literals for exceptions
There was a case being ignored by feross/standard
(standard/standard#198)
@feross

This comment has been minimized.

Copy link
Member

commented Jul 20, 2015

Reported to eslint: eslint/eslint#3099

taromero added a commit to taromero/latte that referenced this issue Jul 20, 2015

Avoid throwing string literals for exceptions
There was a case being ignored by feross/standard
(standard/standard#198)
@feross

This comment has been minimized.

Copy link
Member

commented Jul 24, 2015

Fixed in eslint master :) standard will get the fix the next time we update eslint.

@feross feross closed this Jul 24, 2015

@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
You can’t perform that action at this time.