Function argument alignment causes false positive about indentation

[idan]

So, I have an unfortunate function with a slew of default parameters like so:

export function create (id, xfilter, rawType,
                        width=defaultWidth, height=defaultHeight,
                        footerHeight=defaultFooterHeight,
                        padding=defaultPadding) {
  // ... function body, indented two spaces
}

However this gets me complaints about the function body not being indented 26 spaces. 😦

I tried putting the opening brace on the following line in column zero, and it netted me a separate warning about the brace not being on the same line as the controlling statement.

One way I've found to keep standard happy is by doing this:

export function create (
id, xfilter, rawType,
width=defaultWidth, height=defaultHeight, footerHeight=defaultFooterHeight,
padding=defaultPadding) {
  // ... function body, indented two spaces
}

.. which doesn't read well for me.

Another is this, which is more legible to my eye:

export function create (id, xfilter, rawType,
                        width=defaultWidth, height=defaultHeight,
                        footerHeight=defaultFooterHeight,
                        padding=defaultPadding
) {
  // ... function body, indented two spaces
}

I feel like I'm missing something. What's the proper way to author standardjs-compliant functions with multiline arguments?

[julien-f]

What about this?

export function create (
  id, xfilter, rawType,
  width=defaultWidth, height=defaultHeight,
  footerHeight=defaultFooterHeight,
  padding=defaultPadding
) {
  // ... function body, indented two spaces
}

Anyway, IMHO with so many arguments you should use named parameters with an object and destructuring.

[feross]

@idan What version of standard? Run standard --version.

[idan]

@julien-f that does look nice. In this case I wanted the laziness of default params and with destructuring, I think I'd have to add some extra logic to set the defaults? I need to read up on how that would work.

@feross 4.5.4

[julien-f]

@idan Nope, not so much:

export function create ({
  id, xfilter, rawType,
  width=defaultWidth, height=defaultHeight,
  footerHeight=defaultFooterHeight,
  padding=defaultPadding
} = {}) {
  // ... function body, indented two spaces
}

[idan]

@julien-f nifty! Thanks for the educational moment. 😄

[feross]

@julien-f that's sexy!

This looks like an indentation bug in eslint. Bug filed here: eslint/eslint#3173

[feross]

Fixed in eslint master, so this will be fixed in a future standard release when we upgrade the eslint dependency.