Skip to content

/standard

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New rule: linebreak-style #220

Closed
LinusU opened this issue Aug 4, 2015 · 2 comments

Comments

@LinusU
Copy link
Member

commented Aug 4, 2015

How about including this rule for forcing unix line breaks? I found the rule while comparing which rules xo has versus standard here: #216 (comment)

"linebreak-style": [2,"unix"]
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 4, 2015

This isn't a friendly rule for Windows users. See #140. I think it's best we leave it disabled, unless there's a good reason.
@LinusU

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Aug 4, 2015

Ah, I understand. I've had some problems with the git auto-converter when I've copied files from some source. When I check in a windows-line-endings-file on linux I think it will get marked as 'always windows style' which can cause problems later...

But I think the benefit doesn't outweigh the problem it causes for windows users, closing this.

@LinusU LinusU closed this Aug 4, 2015

@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@LinusU @feross
You can’t perform that action at this time.