Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected "[" and "]" to be on the same line (standard/computed-property-even-spacing) #226

Closed
jprichardson opened this Issue Aug 8, 2015 · 5 comments

Comments

5 participants
@jprichardson
Copy link
Member

jprichardson commented Aug 8, 2015

Using standard@4.5.4 in conjunction with babel-eslint@4.0.5 there is no error in the following code:

import fn from 'fn'

export default function something (args) {
  return fn({
    field: 'blah',
    ...args
  })
}

However, upgrading to standard@5.0.2 an error is thrown:

app.js:6:5: Expected "[" and "]" to be on the same line (standard/computed-property-even-spacing)

Potentially a bug in https://github.com/xjamundx/eslint-plugin-standard/tree/master or is this expected behavior?

@jprichardson

This comment has been minimized.

Copy link
Member Author

jprichardson commented Aug 8, 2015

Sorry, I should have dug around in the proper repo! standard/eslint-plugin-standard#3

@dcousens

This comment has been minimized.

Copy link
Member

dcousens commented Aug 13, 2015

Close?
As standard/eslint-plugin-standard#3 is where this is tracking.
@feross or do we have a blocked-on-eslint-standard-plugin? Ha

@feross

This comment has been minimized.

Copy link
Member

feross commented Aug 14, 2015

This is fixed in standard 5.1.0.

@feross feross closed this Aug 14, 2015

@davidmarkclements

This comment has been minimized.

Copy link

davidmarkclements commented Jan 4, 2016

seems to have returned in 5.4.1:

MacBook-Pro:src davidclements$ standard --version
5.4.1
MacBook-Pro:src davidclements$ standard components/Settings/index.js
standard: Use JavaScript Standard Style (https://github.com/feross/standard)
  /Users/davidclements/z/nearForm/terminal-devtools/src/components/Settings/index.js:17:3: Expected "[" and "]" to be on the same line
14 const settings = {
15  border: null,
16  padding: {left: 1, right: 1},
17  ...bg
18 }
@feross

This comment has been minimized.

Copy link
Member

feross commented Feb 8, 2016

@davidmarkclements Sorry, I can't reproduce your issue with standard v6. Perhaps you can try upgrading?

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.