Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd CHANGELOG #248
Comments
dcousens
added
the
question
label
Sep 5, 2015
This comment has been minimized.
This comment has been minimized.
|
@cesarandreu could you comment on what breaks you experienced? |
This comment has been minimized.
This comment has been minimized.
|
Indeed I think a changelog might be helpful. All the rule changes are captured on |
This comment has been minimized.
This comment has been minimized.
|
https://github.com/feross/eslint-config-standard/commits/master anything beyond 4.1.0 is probably what affected you. |
This comment has been minimized.
This comment has been minimized.
|
I got the following new errors / warnings:
|
This comment has been minimized.
This comment has been minimized.
|
Perhaps https://github.com/rvagg/changelog-maker could be useful for generating changelogs. |
This comment has been minimized.
This comment has been minimized.
This was a long standing rule that was broken in eslint for a small while. It was technically always a
There is a requirement for even/consistent spacing, is this what you mean?
Elaborate? |
This comment has been minimized.
This comment has been minimized.
|
Ah cool, I did not know this existed, @yoshuawuyts :) It looks like its a piece of the puzzle for adding to the node.js changelog (their release instructions have the full details) I'm currently hand-crafting a changelog with the last couple releases just to get something out here (using vmd to preview as I craft them |
This comment has been minimized.
This comment has been minimized.
|
Actually, I am leaning towards something simpler like the format proposed at http://keepachangelog.com/ |
This comment has been minimized.
This comment has been minimized.
|
Added a changelog: It follows http://keepachangelog.com/ conventions. I decided to not list the raw commits and instead tried to make the change log more human readable. A lot of There is also some redundancy; if a dependent package had "Fixed" and "Added" things, its shown twice with a specific list of things for each section. I feel this adds some clarity, especially if there are multiple changes in a dependency. If you have time, please take a look and give some feedback! Thanks! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@Flet looks excellent! |
This comment has been minimized.
This comment has been minimized.
|
I'm usually not a fan of changelog files because they take extra effort to keep up-to-date and this is an all-volunteer effort already, but I do understand the need for end users to quickly find out what changed. Let's try it out and see how it works. |
This comment has been minimized.
This comment has been minimized.
The ternary ( Sorry about that folks -- hopefully won't happen again. I don't think we have any more of these. |
feross
closed this
Sep 5, 2015
This comment has been minimized.
This comment has been minimized.
|
Thanks @feross. I'll happily try to keep it up to date if folks forget |
This comment has been minimized.
This comment has been minimized.
|
An |
This comment has been minimized.
This comment has been minimized.
|
That was really quick, thanks! |
This comment has been minimized.
This comment has been minimized.
|
@Flet: lgtm I'm a fan of the change log. I like to add a link to the diff between each release (e.g. @feross: re:
I understand it can be a bit of a chore, but it definitely helps keep contributors and collaborators more aware of user-facing changes and makes it easier to make a call about patch vs. minor vs. major releases. If it's just a small part of each contribution it starts to take care of itself. :) |
This comment has been minimized.
This comment has been minimized.
|
@bcomnes I've gone through the process you described above, it's not that bad. Just |
This comment has been minimized.
This comment has been minimized.
|
Nice, love the diff link idea. I went ahead and added them (plus diff links going back to 4.0.0). |
This comment has been minimized.
This comment has been minimized.
|
The diff links are handy! |
cesarandreu commentedSep 4, 2015
Updating from 5.1.x to 5.2.x causes my app to break in a few places. I'm fine with with fixing those, but having a CHANGELOG where I can see the changes makes it easier to know what I'll be hunting down.