Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standard --format throws #251

Closed
febeling opened this issue Sep 8, 2015 · 2 comments

Comments

@febeling
Copy link
Contributor

commented Sep 8, 2015

I have a reduced test case, test.js, on which the formatter throws an exception:

for (var i = 0;
     i < 5;
     i++) {
}

This is the stacktrace:

$ standard --format test1.js
/Users/febeling/.node/lib/node_modules/standard/node_modules/standard-format/node_modules/esformatter-semicolon-first/node_modules/espree/espree.js:5489
        throw e;
              ^
Error: Line 2: Unexpected identifier
    at throwError (/Users/febeling/.node/lib/node_modules/standard/node_modules/standard-format/node_modules/esformatter-semicolon-first/node_modules/espree/espree.js:2070:17)
    at throwUnexpected (/Users/febeling/.node/lib/node_modules/standard/node_modules/standard-format/node_modules/esformatter-semicolon-first/node_modules/espree/espree.js:2115:9)
    at expect (/Users/febeling/.node/lib/node_modules/standard/node_modules/standard-format/node_modules/esformatter-semicolon-first/node_modules/espree/espree.js:2142:9)
    at parseForStatement (/Users/febeling/.node/lib/node_modules/standard/node_modules/standard-format/node_modules/esformatter-semicolon-first/node_modules/espree/espree.js:3918:13)
    at parseStatement (/Users/febeling/.node/lib/node_modules/standard/node_modules/standard-format/node_modules/esformatter-semicolon-first/node_modules/espree/espree.js:4314:44)
    at parseSourceElement (/Users/febeling/.node/lib/node_modules/standard/node_modules/standard-format/node_modules/esformatter-semicolon-first/node_modules/espree/espree.js:5176:24)
    at parseSourceElements (/Users/febeling/.node/lib/node_modules/standard/node_modules/standard-format/node_modules/esformatter-semicolon-first/node_modules/espree/espree.js:5214:25)
    at parseProgram (/Users/febeling/.node/lib/node_modules/standard/node_modules/standard-format/node_modules/esformatter-semicolon-first/node_modules/espree/espree.js:5234:12)
    at Object.parse (/Users/febeling/.node/lib/node_modules/standard/node_modules/standard-format/node_modules/esformatter-semicolon-first/node_modules/espree/espree.js:5477:19)
    at Object.parse (/Users/febeling/.node/lib/node_modules/standard/node_modules/standard-format/node_modules/esformatter-semicolon-first/node_modules/rocambole/rocambole.js:69:31)

This is the affected version:

$ npm i -g standard
/Users/febeling/.node/bin/standard -> /Users/febeling/.node/lib/node_modules/standard/bin/cmd.js
standard@5.2.1 /Users/febeling/.node/lib/node_modules/standard
├── eslint-config-standard-react@1.0.4
├── eslint-config-standard@4.3.1
├── eslint-plugin-standard@1.3.0
├── eslint-plugin-react@3.3.1
├── standard-engine@2.0.7 (get-stdin@4.0.1, find-root@0.1.1, xtend@4.0.0, minimist@1.2.0, pkg-config@1.1.0, defaults@1.0.2, dezalgo@1.0.3, multiline@1.0.2, deglob@1.0.1)
├── standard-format@1.6.7 (esformatter-spaced-lined-comment@2.0.1, stdin@0.0.1, esformatter-quotes@1.0.3, minimist@1.2.0, esformatter-eol-last@1.0.0, esformatter-semicolon-first@1.1.0, deglob@1.0.1, esformatter-literal-notation@1.0.1, esformatter-jsx@2.0.11, esformatter@0.7.3)
└── eslint@1.3.1 (escape-string-regexp@1.0.3, path-is-absolute@1.0.0, object-assign@2.1.1, path-is-inside@1.0.1, xml-escape@1.0.0, user-home@1.1.1, strip-json-comments@1.0.4, estraverse-fb@1.3.1, globals@8.8.0, estraverse@4.1.0, text-table@0.2.0, is-resolvable@1.0.0, mkdirp@0.5.1, espree@2.2.4, debug@2.2.0, optionator@0.5.0, chalk@1.1.1, doctrine@0.6.4, concat-stream@1.5.0, minimatch@2.0.10, lodash.merge@3.3.2, lodash.clonedeep@3.0.2, is-my-json-valid@2.12.2, lodash.omit@3.1.0, handlebars@3.0.3, inquirer@0.9.0, js-yaml@3.4.1, escope@3.2.0)

Note that the exception isn't thrown if the loop parenthesis is kept on a single line.

@febeling

This comment has been minimized.

Copy link
Contributor Author

commented Sep 8, 2015

An exception can also be provoked by this file:

function () {
}

creating this stacktrace:

standard --format mini.js

/Users/febeling/.node/lib/node_modules/standard/node_modules/standard-format/node_modules/esformatter-semicolon-first/node_modules/espree/espree.js:5489
        throw e;
              ^
Error: Line 1: Unexpected token (
    at throwError (/Users/febeling/.node/lib/node_modules/standard/node_modules/standard-format/node_modules/esformatter-semicolon-first/node_modules/espree/espree.js:2070:17)
    at throwUnexpected (/Users/febeling/.node/lib/node_modules/standard/node_modules/standard-format/node_modules/esformatter-semicolon-first/node_modules/espree/espree.js:2133:5)
    at parseVariableIdentifier (/Users/febeling/.node/lib/node_modules/standard/node_modules/standard-format/node_modules/esformatter-semicolon-first/node_modules/espree/espree.js:3650:13)
    at parseFunctionDeclaration (/Users/febeling/.node/lib/node_modules/standard/node_modules/standard-format/node_modules/esformatter-semicolon-first/node_modules/espree/espree.js:4575:18)
    at parseSourceElement (/Users/febeling/.node/lib/node_modules/standard/node_modules/standard-format/node_modules/esformatter-semicolon-first/node_modules/espree/espree.js:5163:24)
    at parseSourceElements (/Users/febeling/.node/lib/node_modules/standard/node_modules/standard-format/node_modules/esformatter-semicolon-first/node_modules/espree/espree.js:5214:25)
    at parseProgram (/Users/febeling/.node/lib/node_modules/standard/node_modules/standard-format/node_modules/esformatter-semicolon-first/node_modules/espree/espree.js:5234:12)
    at Object.parse (/Users/febeling/.node/lib/node_modules/standard/node_modules/standard-format/node_modules/esformatter-semicolon-first/node_modules/espree/espree.js:5477:19)
    at Object.parse (/Users/febeling/.node/lib/node_modules/standard/node_modules/standard-format/node_modules/esformatter-semicolon-first/node_modules/rocambole/rocambole.js:69:31)
    at Object.exports.stringBefore (/Users/febeling/.node/lib/node_modules/standard/node_modules/standard-format/node_modules/esformatter-semicolon-first/esformatter-semicolon-first.js:39:23)
@feross

This comment has been minimized.

Copy link
Member

commented Sep 8, 2015

This is an issue with the standard formatter. Please open an issue on standard-format.

@feross feross closed this Sep 8, 2015

@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
You can’t perform that action at this time.