Chained calls with object argument indentation

[albertorestifo]

Before the latest Standard update I could do this:

promiseFooBar({
    foo: true,
    bar: false
  })
  .then(fooBar => console.log(fooBar))
  .catch(err => console.log(err))

Now the new indentation rules forces me to do either of the following:

// 1
promiseFooBar({
  foo: true,
  bar: false
})
  .then(fooBar => console.log(fooBar))
  .catch(err => console.log(err))

// 2
promiseFooBar({
  foo: true,
  bar: false })
  .then(fooBar => console.log(fooBar))
  .catch(err => console.log(err))

// 3
promiseFooBar({
  foo: true,
  bar: false
}).then(fooBar => console.log(fooBar))
  .catch(err => console.log(err))

I was very happy using the first example, now not allowed. I understand and respect that the Standard rules are not up to discussion, so I just want to ask:

What way should I indent them?

[albertorestifo]

Forgot one, that's what I've been using since the update

// 4
const options = { foo: true, bar: false }

promiseFooBar(options)
  .then(fooBar => console.log(fooBar))
  .catch(err => console.log(err))

[yoshuawuyts]

they all lgtm except:

promiseFooBar({
  foo: true,
  bar: false })
  .then(fooBar => console.log(fooBar))
  .catch(err => console.log(err))

[pbrinkmeier]

What about that (is more semantic IMO):

promiseFooBar({
  foo: true,
  bar: false
})
.then(fooBar => console.log(fooBar))
.catch(err => console.log(err))

[albertorestifo]

@reg4in It makes it harder to detect a chained call when looking at a lot of code.

But yeah, it also satisfies the Standard rules, so it's a valid option

[pbrinkmeier]

@albertorestifo I personally don't think so but I won't force anyone to use it 😛

[dcousens]

Before the latest Standard update I could do this:

Which versions specifically?

[emgeee]

I did some digging into this and it looks to have cropped up starting in v5.0.0 when the indent rule got stricter. As far as I can tell, this is an issue relating to how eslint handles the indent rule and isn't something standard can do much about.

There looks to be an open issue for eslint here: eslint/eslint#3614 that discusses adding more customization around indentation and chaining.

[albertorestifo]

@emgeee 👍 Exactly, update to 5.0.0 is what did it for me

[feross]

Yeah, unfortunately eslint reimplemented the indent rule and it got stricter in some edge cases.

There's nothing we can do about it.