Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUse eslint-plugin-jsdoc #263
Comments
This comment has been minimized.
This comment has been minimized.
|
I'm just concerned that not everyone uses jsdoc for |
This comment has been minimized.
This comment has been minimized.
|
If this forces all users to use JSDoc comments, then it's a non starter. How does this behave for |
This comment has been minimized.
This comment has been minimized.
|
Also, what is the performance hit of adding this? |
This comment has been minimized.
This comment has been minimized.
What are the variations? Isn't the point of "standard" package to standardise the code style? Whether JSDoc (comments) include code or not, is another question. Though having consistent comment blocks across different projects make reading code easier. |
This comment has been minimized.
This comment has been minimized.
|
The point is that lots of people use block comments to write comments that span multiple lines. It's not okay to force those to all be JSDoc. |
This comment has been minimized.
This comment has been minimized.
Please include examples whenever describing use scenarios. |
This comment has been minimized.
This comment has been minimized.
It takes you to think of one example and write it down. When example is not included, it requires that every participant thinks of their own example and these examples are not necessarily the same. Does not help to the discussion. |
This comment has been minimized.
This comment has been minimized.
/**
* This is a block comment. This is not JSDoc.
*/ |
This comment has been minimized.
This comment has been minimized.
|
This is perfectly valid JSDoc comment block. It just does not have property definitions. |
This comment has been minimized.
This comment has been minimized.
|
It might be interesting to run these rules via clone.js to see what issues might come up. |
This comment has been minimized.
This comment has been minimized.
|
It looks like adding this plugin would add dependencies on jscs alone requires all these packages and we're trying to make the install faster (#340)
|
feross
closed this
Nov 21, 2015
This comment has been minimized.
This comment has been minimized.
|
Just in case, we are working on removing the JSCS dependency. Will update when it is removed. |
This comment has been minimized.
This comment has been minimized.
|
@feross JSCS has been removed as a dependency from v2. |
gajus commentedSep 19, 2015
Consider using
eslint-plugin-jsdocto enforce a specific style of JSDoc comments.I propose the standard setup:
{ "rules": { "jsdoc/check-param-names": 1, "jsdoc/check-redundant-params": 1, "jsdoc/check-redundant-returns": 1, "jsdoc/require-return-types": 1, "jsdoc/newline-after-description": 1, "jsdoc/require-description-complete-sentence": 1, "jsdoc/require-param-description": 1, "jsdoc/require-param-types": 1, "jsdoc/require-return-types": 1 } }