Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing space before function parentheses after formatting code #264

Closed
chenxsan opened this issue Sep 19, 2015 · 4 comments

Comments

@chenxsan
Copy link
Member

commented Sep 19, 2015

I'm playing on the site http://standardjs.com/demo.html, after pressing Format Code button, I got these:

screen shot 2015-09-19 at 21 30 38

I have to insert a space after hello function as hello () {}, then something is wrong with the Format Code?

@dcousens dcousens added the bug label Sep 19, 2015

@pbrinkmeier

This comment has been minimized.

Copy link

commented Sep 20, 2015

No, that actually is a part of the standard. Read the Readme carefully.
https://github.com/feross/standard#rules
The seventh bullet.

@chenxsan

This comment has been minimized.

Copy link
Member Author

commented Sep 20, 2015

@reg4in The Format Code button would give me hello() {}, not hello () {}.

@dcousens

This comment has been minimized.

Copy link
Member

commented Sep 20, 2015

@chenxsan I'm pretty certain this is a bug to be filed over at https://github.com/maxogden/standard-format.

You are correct that hello () {} is what should have been output.

@feross

This comment has been minimized.

Copy link
Member

commented Sep 20, 2015

Yeah, this is a bug in standard-format. I moved the issue there: maxogden/standard-format#116

@feross feross closed this Sep 20, 2015

@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
You can’t perform that action at this time.