Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not handles error locally, but handle it on travis ci #272

Closed
tunnckoCore opened this issue Sep 23, 2015 · 3 comments

Comments

@tunnckoCore
Copy link

commented Sep 23, 2015

I was surprised. I don't know what, but it seems something is not okey.
I have try catch block like that in which dont have space between parenthesis and the end of catch keyword.

try {
  // stuff
} catch(err) {
  throw err
}

Running standard it not outputs any errors (locally), but it fails in travis with

standard: Use JavaScript Standard Style (https://github.com/feross/standard) 
  /home/travis/build/tunnckoCore/octet/index.js:53:7: Keyword "catch" must be followed by whitespace.

Just wanted to notify you :)

@Flet

This comment has been minimized.

Copy link
Member

commented Sep 23, 2015

Looking at https://github.com/tunnckoCore/octet/blob/master/.travis.yml I see that standard is installed via travis.

Also looking at package.json there is no dependency on standard, so locally you must have standard installed globally?

Perhaps your global copy of standard is not up to date? Have you tried running npm i -g standard locally to update?

It seems unconventional to me to have travis install standard in this way. Is there a reason you're doing it like this? Usually I have standard in devDependencies.

@tunnckoCore

This comment has been minimized.

Copy link
Author

commented Sep 23, 2015

Yea I have it globally, as many other tools. There's few reasons why i do it like that:

  • I absolutely don't like to have them in devDeps
  • they are too big (eslints, istanbuls, coverage tools, testing runners/frameworks and etc)
  • there's no logic to loose time to install them every time, i dont have that time

I usually keep it up-to-date, currently it is 5.2.2 and just noticed that it is outdated from a while. And yea that's the key (or something other from 4.4.0).

Just forgot to check before open the issue. :)
Cheers.

edit: yep, works after the update.

@tunnckoCore

This comment has been minimized.

Copy link
Author

commented Sep 23, 2015

It's a lot better and enough to set one badge to say "this repo use standard code style" and one contributing file which guides you how to contribute correctly. Meanwhile it answers why your PR may fail.

btw, just noticed that changelog isn't modified since 5.2.2

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
You can’t perform that action at this time.