Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upNot handles error locally, but handle it on travis ci #272
Comments
This comment has been minimized.
This comment has been minimized.
|
Looking at https://github.com/tunnckoCore/octet/blob/master/.travis.yml I see that Also looking at Perhaps your global copy of It seems unconventional to me to have travis install standard in this way. Is there a reason you're doing it like this? Usually I have |
This comment has been minimized.
This comment has been minimized.
|
Yea I have it globally, as many other tools. There's few reasons why i do it like that:
I usually keep it up-to-date, currently it is 5.2.2 and just noticed that it is outdated from a while. And yea that's the key (or something other from 4.4.0). Just forgot to check before open the issue. :) edit: yep, works after the update. |
tunnckoCore
closed this
Sep 23, 2015
This comment has been minimized.
This comment has been minimized.
|
It's a lot better and enough to set one badge to say "this repo use standard code style" and one contributing file which guides you how to contribute correctly. Meanwhile it answers why your PR may fail. btw, just noticed that changelog isn't modified since 5.2.2 |
tunnckoCore commentedSep 23, 2015
I was surprised. I don't know what, but it seems something is not okey.
I have try catch block like that in which dont have space between parenthesis and the end of catch keyword.
Running
standardit not outputs any errors (locally), but it fails in travis withJust wanted to notify you :)