Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upInclude minification note #278
Comments
This comment has been minimized.
This comment has been minimized.
|
are there known minifiers that don't work? I'm under the assumption here that most production-grade minifiers today should be able to handle semicolon-less JS. |
This comment has been minimized.
This comment has been minimized.
|
@rstacruz I've always used semicolons and I never give it a thought to ASI support in minifiers since I'm used to lint before minification. When I decided to try to this style it was one of my first concerns, I had to read the minifier docs to realize it's all good. Perhaps this knowledge shouldn't be assumed... someone could that have the same concern and finding a note in standard would be useful. As you phrase would suffice "most production-grade minifiers today should be able to handle semicolon-less JS." |
dcousens
added
the
question
label
Oct 2, 2015
This comment has been minimized.
This comment has been minimized.
|
@gaboesquivel PR welcome! It is probably worth mentioning. |
This comment has been minimized.
This comment has been minimized.
|
PR sent: #341 |
feross
closed this
in
f630bc1
Nov 21, 2015
jprichardson
added a commit
that referenced
this issue
Nov 21, 2015
lock
bot
locked as resolved and limited conversation to collaborators
May 10, 2018
gaboesquivel commentedOct 1, 2015
It believe it is important to include a note ( perhaps under FAQ ) on relation to minification. Mention that UglifyJS2 will safely minify the javascript since it does ASI by default.