Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard Flow Typing #306

Closed
thomas-jeepe opened this issue Oct 26, 2015 · 5 comments

Comments

@thomas-jeepe
Copy link

commented Oct 26, 2015

I'm just putting this out there because the formatter doesn't work with flow.

If you were to put it in, I would just go with

// colon on variable
var foo: string = 'blah'

// regular array type
var array: Array<string> = ['hi']

// semi colons on each property
var obj: {a: string; b: number;} = {a:'hi',b:1}

or something of the sort

@jprichardson

This comment has been minimized.

Copy link
Member

commented Oct 26, 2015

@penguinsoccer why not just do typing via the comments? http://flowtype.org/blog/2015/02/20/Flow-Comments.html

@thomas-jeepe

This comment has been minimized.

Copy link
Author

commented Oct 26, 2015

That is a lot more code. It will add up over time

@yoshuawuyts

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2015

Meh, the jsx part of standard is already bloated and huge (it has a significant impact on download time). Support for more non-standard extensions to the language is probably a bad idea.

Instead consider forking standard to create a standard-flow or similar using the necessary dependencies to satisfy your needs.

@thomas-jeepe

This comment has been minimized.

Copy link
Author

commented Nov 1, 2015

@yoshuawuyts The problem with that is that the parser does not support flow typing so it is impossible with that unless I take the flow parser and make it custom which would take far too long :(

@Flet

This comment has been minimized.

Copy link
Member

commented Dec 10, 2015

Sorry, I don't think this will be possible without significant enhancements to upstream dependencies or custom code. Closing this for now.

@Flet Flet closed this Dec 10, 2015

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
You can’t perform that action at this time.