Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upNobody write a space after function name #311
Comments
This comment has been minimized.
This comment has been minimized.
|
The title of this issue is inaccurate. Currently every user of this module uses spaces after function names. This is a great example of bikeshedding. Please read https://github.com/feross/standard#i-disagree-with-rule-x-can-you-change-it |
This comment has been minimized.
This comment has been minimized.
|
@tkrotoff Thanks for sharing your opinion about this issue. It's not open for discussion, though. |
feross
closed this
Oct 30, 2015
This comment has been minimized.
This comment has been minimized.
|
The npm name is "standard", the title is "JavaScript Standard Style", the moto is "One Style to Rule Them All" and not something like "Feross JS Style Guide", "Airbnb JS Style Guide", "Google JS Style Guide". A name like this come with responsibilities. |
This comment has been minimized.
This comment has been minimized.
|
Let's be honest: this is an pretty unimportant issue. You might be able to find some minor reasons why your preferred style is better than the other style, but others can come up with reasons why their choice is better than yours, too. It doesn't matter which choice we pick. Both choices are valid. Neither choice will lead to more bugs or programmer errors. So, we just need to pick something. What exactly are you proposing? That we change the rule and force 100K+ monthly users to change all their code? Sorry - not happening. You're free to use another style guide, to extend eslint-config-standard, or even to fork |
standard
locked and limited conversation to collaborators
Oct 30, 2015
This comment has been minimized.
This comment has been minimized.
|
Alternatively, just use anonymous arrow functions and you won't even know |
tkrotoff commentedOct 29, 2015
You recommend to write
function name (arg) { ... }instead offunction name(arg) { ... }.It seems you are the only one among the JavaScript style guides (*) to recommend that:
Consequence, you also recommend to write:
instead of
None of the popular programming languages out there do that:
And last, statistics show that most people (67%) don't write a space after function in JavaScript.
Related issues: #89, #164, #217
(*) listed on Google first page