Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use double quotes in jsx content? #315

Closed
leecade opened this issue Nov 3, 2015 · 5 comments

Comments

@leecade
Copy link

commented Nov 3, 2015

I think double quotes is better, this code is html-like and the code with double quotes which auto generated by editor

class User extend Component {
  render () {
    return <div className="class">
    </div>
  }
}

@dcousens dcousens added the question label Nov 3, 2015

@dcousens

This comment has been minimized.

Copy link
Member

commented Nov 3, 2015

Doing this would be a major breaking change for me, and is inconsistent with our general style.
-1.

@rstacruz

This comment has been minimized.

Copy link
Member

commented Nov 3, 2015

also, it offers no benefit. html supports single-quotes just fine. -1.

@leecade

This comment has been minimized.

Copy link
Author

commented Nov 4, 2015

@dcousens ok, let me see how to change the rule of emmet

@dcousens

This comment has been minimized.

Copy link
Member

commented Nov 5, 2015

emmet?

@dcousens dcousens closed this Nov 5, 2015

@leecade

This comment has been minimized.

Copy link
Author

commented Nov 5, 2015

@dcousens yeah I use Emmet write jsx

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.