Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: catch duplicate attributes #317

Closed
rstacruz opened this issue Nov 5, 2015 · 3 comments

Comments

@rstacruz
Copy link
Member

commented Nov 5, 2015

no-dupe-keys catches these duplicates in an Object:

console.log({ hi: 1, hi: 1 })

but not these attributes in a React element:

import React from 'react'

window.hi(<div hi='1' hi='1'></div>)

@dcousens dcousens added the bug label Nov 5, 2015

@dtinth

This comment has been minimized.

Copy link

commented Nov 8, 2015

@dcousens

This comment has been minimized.

Copy link
Member

commented Nov 8, 2015

@Flet

This comment has been minimized.

Copy link
Member

commented Dec 10, 2015

Cool this has been published in eslint-config-standard-react@1.2.1 which was added to standard@5.4.0 via 80cc954

Closing!

@Flet Flet closed this Dec 10, 2015

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
You can’t perform that action at this time.