Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upCodeclimate engine #342
Comments
This comment has been minimized.
This comment has been minimized.
|
Getting standard into code climate would be great! |
This comment has been minimized.
This comment has been minimized.
|
I'm not super familiar with docker, but I'm happy to test this. |
This comment has been minimized.
This comment has been minimized.
|
I started by making a formatting module to output things in the format that CodeClimate is expecting: https://www.npmjs.com/package/standard-codeclimate Next step would be to fiddle with the docker stuff. I'll get to it as I have spare time, but if anyone else wants to take the initiative, feel free :) |
This comment has been minimized.
This comment has been minimized.
|
Nice @jden! It should not be difficult to dockerize this at all! I'll try to find time to play. |
This comment has been minimized.
This comment has been minimized.
|
Do folks still have interest in this? |
feross
added
the
meta
label
Feb 5, 2016
This comment has been minimized.
This comment has been minimized.
|
I'd be interested. Currently I have standard running in my travis ci tests and codeclimate running as a separate github integration. Not a huge deal, but nice to see the different between test errors and style / lint errors when reviewing PRs. Codeclimate has a first-party jslint or eshint or whatever engine, but I disable it. |
This comment has been minimized.
This comment has been minimized.
|
Looks like there's support for I think this can be closed now, right? |
feross
closed this
Jun 5, 2016
This comment has been minimized.
This comment has been minimized.
martinheidegger
commented
Jan 20, 2017
|
I think this needs to be reopened. I tried standard with code climate and the suggested setup uses eslintrc which is not at all cool for following reasons:
|
This comment has been minimized.
This comment has been minimized.
|
@martinheidegger I think you might be right - that doesn't sound very easy to use! I think this issue should be taken up directly with the codeclimate team. I don't know how codeclimate works because I don't use it. This is most likely to get fixed if it's championed by someone who understands the issue better. Feel free to post updates to this issue to keep other codeclimate users like @bcomnes and @jsdnxx up-to-date so they can leave their thoughts in the issue too. |
This comment has been minimized.
This comment has been minimized.
|
I'm not using code climate at the moment, so my motivation is low for the time being. |
junosuarez commentedNov 21, 2015
This is not a feature request for the
standardcli repo, but rather an enhancement idea for the standard community.Codeclimate is a popular code quality tool that integrates with github PRs. It supports add-on "engines" via Docker containers. The spec is https://github.com/codeclimate/spec
I'm interested in working on this, but not sure when I'll find the time. Is anyone else interested in this, either in developing or testing?