Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeclimate engine #342

Closed
junosuarez opened this issue Nov 21, 2015 · 10 comments

Comments

@junosuarez
Copy link

commented Nov 21, 2015

This is not a feature request for the standard cli repo, but rather an enhancement idea for the standard community.

Codeclimate is a popular code quality tool that integrates with github PRs. It supports add-on "engines" via Docker containers. The spec is https://github.com/codeclimate/spec

I'm interested in working on this, but not sure when I'll find the time. Is anyone else interested in this, either in developing or testing?

@bcomnes

This comment has been minimized.

Copy link
Member

commented Nov 23, 2015

Getting standard into code climate would be great!

@feross

This comment has been minimized.

Copy link
Member

commented Dec 2, 2015

I'm not super familiar with docker, but I'm happy to test this.

@junosuarez

This comment has been minimized.

Copy link
Author

commented Dec 2, 2015

I started by making a formatting module to output things in the format that CodeClimate is expecting: https://www.npmjs.com/package/standard-codeclimate

Next step would be to fiddle with the docker stuff. I'll get to it as I have spare time, but if anyone else wants to take the initiative, feel free :)

@Flet

This comment has been minimized.

Copy link
Member

commented Dec 10, 2015

Nice @jden! It should not be difficult to dockerize this at all! I'll try to find time to play.

@feross

This comment has been minimized.

Copy link
Member

commented Feb 5, 2016

Do folks still have interest in this?

@feross feross added the meta label Feb 5, 2016

@junosuarez

This comment has been minimized.

Copy link
Author

commented Feb 5, 2016

I'd be interested. Currently I have standard running in my travis ci tests and codeclimate running as a separate github integration. Not a huge deal, but nice to see the different between test errors and style / lint errors when reviewing PRs. Codeclimate has a first-party jslint or eshint or whatever engine, but I disable it.

@junosuarez junosuarez referenced this issue Feb 12, 2016
0 of 1 task complete
@feross

This comment has been minimized.

Copy link
Member

commented Jun 5, 2016

Looks like there's support for standard in codeclimate now. See:

I think this can be closed now, right?

@feross feross closed this Jun 5, 2016

@martinheidegger

This comment has been minimized.

Copy link

commented Jan 20, 2017

I think this needs to be reopened. I tried standard with code climate and the suggested setup uses eslintrc which is not at all cool for following reasons:

  1. eslint-plugin-standard, etc. require eslint@3 which in turn requires node@>4 which means my lint tests don't run in node@0.12 😢
  2. Not having to setup a eslintrc and a eslintignore and adding three lines to my package.json is the reason why I like love standard.
@feross

This comment has been minimized.

Copy link
Member

commented Jan 21, 2017

@martinheidegger I think you might be right - that doesn't sound very easy to use!

I think this issue should be taken up directly with the codeclimate team. I don't know how codeclimate works because I don't use it. This is most likely to get fixed if it's championed by someone who understands the issue better.

Feel free to post updates to this issue to keep other codeclimate users like @bcomnes and @jsdnxx up-to-date so they can leave their thoughts in the issue too.

@bcomnes

This comment has been minimized.

Copy link
Member

commented Jan 23, 2017

I'm not using code climate at the moment, so my motivation is low for the time being.

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
You can’t perform that action at this time.