Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks with latest babel-eslint #348

Closed
gnunicorn opened this issue Nov 30, 2015 · 7 comments

Comments

@gnunicorn
Copy link

commented Nov 30, 2015

Running standard using the latest version of babel-eslint fails with an internal error:

 ./node_modules/standard/bin/cmd.js **/**.jsx
standard: Unexpected linter output:

TypeError: Cannot read property 'loc' of undefined
    at EventEmitter.validateSpacingBeforeParentheses (/Users/ben/dev/beavy/node_modules/standard/node_modules/standard-engine/node_modules/eslint/lib/rules/space-before-function-paren.js:92:29)
    at emitOne (events.js:82:20)
    at EventEmitter.emit (events.js:169:7)
    at NodeEventGenerator.enterNode (/Users/ben/dev/beavy/node_modules/standard/node_modules/standard-engine/node_modules/eslint/lib/util/node-event-generator.js:42:22)
    at CommentEventGenerator.enterNode (/Users/ben/dev/beavy/node_modules/standard/node_modules/standard-engine/node_modules/eslint/lib/util/comment-event-generator.js:98:23)
    at Controller.controller.traverse.enter (/Users/ben/dev/beavy/node_modules/standard/node_modules/standard-engine/node_modules/eslint/lib/eslint.js:771:36)
    at Controller.__execute (/Users/ben/dev/beavy/node_modules/standard/node_modules/standard-engine/node_modules/eslint/node_modules/estraverse/estraverse.js:397:31)
    at Controller.traverse (/Users/ben/dev/beavy/node_modules/standard/node_modules/standard-engine/node_modules/eslint/node_modules/estraverse/estraverse.js:495:28)
    at EventEmitter.module.exports.api.verify (/Users/ben/dev/beavy/node_modules/standard/node_modules/standard-engine/node_modules/eslint/lib/eslint.js:768:24)
    at processText (/Users/ben/dev/beavy/node_modules/standard/node_modules/standard-engine/node_modules/eslint/lib/cli-engine.js:225:27)

Versions used:

  • babel-eslint: 5.0.0-beta4
  • standard: 5.4.1
@SEAPUNK

This comment has been minimized.

Copy link

commented Dec 4, 2015

+1, would be awesome if standard started working again.

@hzoo

This comment has been minimized.

Copy link

commented Dec 9, 2015

Published babel-eslint@5.0.0-beta6 which hopefully fixes getters/setters.

@SEAPUNK

This comment has been minimized.

Copy link

commented Dec 9, 2015

@hzoo Looks like it's working pretty well now; thanks!

@Flet

This comment has been minimized.

Copy link
Member

commented Dec 10, 2015

Cool, so can this be closed @SEAPUNK?

@SEAPUNK

This comment has been minimized.

Copy link

commented Dec 10, 2015

@Flet With my code, sure. I don't know if it will still work w/ @ligthyear's code, though.

Personally, I'd close this issue, since this is still primarily a babel-eslint problem.

@Flet

This comment has been minimized.

Copy link
Member

commented Dec 10, 2015

Closing. @ligthyear feel free to add a comment if this doesn't make sense.

@Flet Flet closed this Dec 10, 2015

@gnunicorn

This comment has been minimized.

Copy link
Author

commented Dec 11, 2015

Not sure this is actual babel-eslint's problem. We solved it by using babel-eslint with the standard-profile instead. So I can neither confirm nor deny that this still broken at the moment.

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
You can’t perform that action at this time.