Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semicolons? #375

Closed
jantimon opened this issue Jan 8, 2016 · 3 comments

Comments

@jantimon
Copy link

commented Jan 8, 2016

Using semicolons is the javascript community convention.
All big community projects are using semicolons:

Even the v8 engine itself is using them: https://github.com/v8/v8/blob/master/src/js/array.js

Could you please give me some examples of huge projects which might pass your "standard"?

If you are using React, Angular, Node, Gulp, Grunt, Webpack, jQuery, Lodash, Modernizr, V8 (...) in the same project where you want to use feross/standard your brain has to switch between the real community standard and the feross/standard all the time.

@rstacruz

This comment has been minimized.

Copy link
Member

commented Jan 8, 2016

It isn't necessarily about the number of projects though. semicolon-less JavaScript has been increasing in adoption and more and more people prefer it now.

@jantimon

This comment has been minimized.

Copy link
Author

commented Jan 8, 2016

It feels more like that the coffeescript users realised that coffeescript is dying and try to keep their habits.

And the number matters - if it is rejected by 90% of the github javascript code it does not deserve the name standard.

From the readme: "Adopting standard style means ranking the importance of code clarity and community conventions higher than personal style."

Placing semicolons is the community convention.

@yoshuawuyts

This comment has been minimized.

Copy link
Contributor

commented Jan 8, 2016

Dupes #5, #78, #79, and #176. Check out the explanation on #78 in particular. You might find semistandard useful: https://github.com/Flet/semistandard.

See also https://github.com/feross/standard#i-disagree-with-rule-x-can-you-change-it

@yoshuawuyts yoshuawuyts closed this Jan 8, 2016

@standard standard locked and limited conversation to collaborators Jan 8, 2016

@dcousens dcousens added the i disagree label Jan 11, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
You can’t perform that action at this time.