Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint v2.0.0-rc1 required, which is not noted in WebStorm documentation #409

Closed
vulpino opened this issue Feb 6, 2016 · 5 comments

Comments

@vulpino
Copy link

commented Feb 6, 2016

Given the .eslintrc file:

{
  "extends": ["standard", "standard-jsx"],
  "plugins": ["react"],
  "ecmaFeatures": {
    "jsx": true
  },
  "env": {}
}

The following error ocurrs:

"C:\Program Files\nodejs\node.exe" F:\Projects\mister\node_modules\eslint\bin\eslint.js --format=checkstyle --stdin --stdin-filename src\client\main.js
standard:
    Configuration for rule "no-labels" is invalid:
    Value "2,[object Object]" has more items than allowed.

The issue appears to be caused because Standard requires a release candidate version of eslint (v2.0.0-rc1). The documentation for WebStorm recommends running npm install -g eslint eslint-config-standard eslint-plugin-standard, but these will install the newer version of eslint-config-standard and eslint-plugin-standard which have rules that apparently depend on a newer version of eslint. The issue is fixed by installing eslint v2.0.0-rc1 explicitly, but the WebStorm documentation should be updated to recommend explicitly installing v2.0.0-rc1 (or somewhere along the process outside of the standard package it should be explicitly required).

@feross

This comment has been minimized.

Copy link
Member

commented Feb 7, 2016

Yes, you're right. I jumped the gun a bit and may have released standard 6 a bit too early. Next time, I'll wait for the stable eslint release.

Documentation is updated.

@feross feross closed this in 690984d Feb 7, 2016

@knownasilya

This comment has been minimized.

Copy link

commented Feb 15, 2016

Even with Eslint 2.0, it fails with Node 5.6 https://travis-ci.org/Strider-CD/core/jobs/109256135#L859

@vanjan

This comment has been minimized.

Copy link

commented Feb 15, 2016

This can now be reverted, since eslint@2.0.0 has been released.

@feross

This comment has been minimized.

Copy link
Member

commented Feb 15, 2016

@vanjan Thanks, reverted.

@feross

This comment has been minimized.

Copy link
Member

commented Feb 15, 2016

@knownasilya Please update to the latest version of snazzy (3.0.0) which was just published.

@feross feross added the question label Feb 15, 2016

feross added a commit that referenced this issue Feb 15, 2016

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
You can’t perform that action at this time.