Closing bracket alignment

[mike-engel]

Just upgraded to 6.0.1, which has been great and provided even more (missing) consistency. I do feel like the closing bracket rule should either be modified or removed. What I believe the rule is trying to enforce:

// bad
<div>
  Some content</div>

<div>
  Some content
  </div>

// good!
<div>
  some content
</div>

Which is great! But with self-closing tags with a lot of attributes, it gets tricky.

// errors
<Link to={this.props.page === 1 ? 'javascript:void(0)' : `/?page=${this.props.page - 1}`}
  className={this.props.page === 1 ? 'pagination__link disabled' : 'pagination__link'}
  onClick={this.props.page === 1 ? () => {} : this.getMoreBookmarks}
  disabled={this.props.page === 1}
  data-hook='previous'>
    &#x276e; Previous
</Link>

<SearchForm dispatch={props.dispatch}
  history={props.history}
  searchTerm={props.searchTerm} />

This is probably an error with ESLint, but I figured I'd start here first. Thanks!

[feross]

Try this instead:

<Link to={this.props.page === 1 ? 'javascript:void(0)' : `/?page=${this.props.page - 1}`}
  className={this.props.page === 1 ? 'pagination__link disabled' : 'pagination__link'}
  onClick={this.props.page === 1 ? () => {} : this.getMoreBookmarks}
  disabled={this.props.page === 1}
  data-hook='previous'
>
  &#x276e; Previous
</Link>

<SearchForm dispatch={props.dispatch}
  history={props.history}
  searchTerm={props.searchTerm}
/>

[mike-engel]

Thanks @feross. I can do that, just looks a bit silly.

[feross]

Writing it like this makes more sense, to me:

<Link
  to={this.props.page === 1 ? 'javascript:void(0)' : `/?page=${this.props.page - 1}`}
  className={this.props.page === 1 ? 'pagination__link disabled' : 'pagination__link'}
  onClick={this.props.page === 1 ? () => {} : this.getMoreBookmarks}
  disabled={this.props.page === 1}
  data-hook='previous'
>
  &#x276e; Previous
</Link>

<SearchForm
  dispatch={props.dispatch}
  history={props.history}
  searchTerm={props.searchTerm}
/>

[mike-engel]

Yeah, definitely looks better. I'll experiment with it. Thanks again!