Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better JSX handling #415

Closed
nickcolley opened this issue Feb 10, 2016 · 3 comments

Comments

@nickcolley
Copy link
Contributor

commented Feb 10, 2016

I love Standard but it falls down with JSX, is the project looking to be transparently opinionated like it is with the rest of JS, or is this something that'd need to be in a fork?

Things like https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-curly-spacing.md for example is a pain to not have consistent.

@yoshuawuyts

This comment has been minimized.

Copy link
Contributor

commented Feb 10, 2016

Oh yeah, that rule seems reasonable, PR welcome!

Regarding JSX - I think the reason it's less thorough might be because there've been less contributions to JSX compared to other rules. We don't particularly have a policy regarding what is / isn't acceptable as a rule - it's determined on a case-by-case basis. If you run into anything that you think should be part of standard, open a PR and we'll be happy to review it. Cheers!

@nickcolley

This comment has been minimized.

Copy link
Contributor Author

commented Feb 10, 2016

That's great to hear thanks for the quick reply, I'll open a PR at https://github.com/feross/eslint-config-standard-jsx

@nickcolley nickcolley closed this Feb 10, 2016

@feross

This comment has been minimized.

Copy link
Member

commented Feb 10, 2016

The jsx-curly-spacing rule is already enabled with the following config:

    "react/jsx-curly-spacing": [2, "never"]

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.