Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRule suggestion: Enforce padding between class functions #438
Comments
This comment has been minimized.
This comment has been minimized.
|
sure, seems reasonable |
dcousens
added
the
enhancement
label
Feb 24, 2016
This comment has been minimized.
This comment has been minimized.
|
There's no eslint core rule for this? @LinusU can you propose it on the eslint repo? |
feross
added
the
blocked
label
Apr 24, 2016
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I also created a working rule |
This comment has been minimized.
This comment has been minimized.
|
@LinusU Nice work! Please post a comment here / send a PR when that's merged and released in ESLint so we can add this rule to |
This comment has been minimized.
This comment has been minimized.
|
Will do |
This comment has been minimized.
This comment has been minimized.
|
@LinusU Looks like progress is going well on this rule -- it's almost there! I'm going to close this issue since it's already being tracked in the ESLint repo and there's nothing for us to do here. Please open a new issue or PR when this rule is actually added to ESLint and I'll enable it. If you forget, no worries either. Every time I update ESLint, I evaluate every new rule for inclusion in |
feross
closed this
Aug 19, 2016
This comment has been minimized.
This comment has been minimized.
|
It has finally landed |
LinusU
reopened this
Oct 2, 2017
This comment has been minimized.
This comment has been minimized.
|
Landed in eslint 4.9.0 |
Flet
added this to the
standard v11 milestone
Nov 7, 2017
feross
removed
the
blocked
label
May 3, 2018
feross
modified the milestones:
standard v12,
standard v13
Aug 28, 2018
This comment has been minimized.
This comment has been minimized.
|
Let's include this in Ecosystem impact: only one failing package ( |
LinusU commentedFeb 24, 2016
I would like to propose a rule that enforces consistent spacing between class functions.
The following patterns would be considered problems:
The following pattern would be considered valid: