Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single linter (eliminate jscs) #45

Closed
feross opened this issue Feb 26, 2015 · 7 comments

Comments

@feross
Copy link
Member

commented Feb 26, 2015

Using just a single linter would simplify standard, and even speed it up (#43).

eslint is excellent, and we've been slowly moving rules from jscs to eslint whenever possible. There are only a few rules that are unique to jscs at this point. The eslint project wants to support jscs options that make sense, so I think we'll be able to switch entirely very soon. These are the options we're waiting for:

@Flet Flet referenced this issue Mar 3, 2015

feross added a commit that referenced this issue Mar 4, 2015

@feross

This comment has been minimized.

Copy link
Member Author

commented Mar 4, 2015

eslint just added a rule for requiring spaces in a for statement. 1 down, just 3 left to go!

Once this issue is fixed, we'll get free JSX support #47, and free speed #43.

feross added a commit that referenced this issue Mar 4, 2015

@feross

This comment has been minimized.

Copy link
Member Author

commented Mar 19, 2015

Discussed with @othiym23 and we agreed that it's probably fine to eliminate jscs after the first issue (disallow multiple var declaration (eslint/eslint#1619)) is fixed. The rest are less important, and we can just re-add them when eslint gets them.

feross added a commit that referenced this issue Mar 19, 2015

feross added a commit that referenced this issue Mar 19, 2015

Significant speed increase / remove jscs linter
Improves performance of standard by 2-4x by:

- remove the need for `npm run which-eslint`
- remove the `child_process.exec` calls and use the node api of eslint
directly
- Remove `jscs` linter

Fixes #43 - speed issues
Fixes #45 - eliminate jscs

Lays the groundwork for #60 - programmatic use

@feross feross self-assigned this Mar 19, 2015

@mightyiam

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2015

Awesome.

feross added a commit that referenced this issue Mar 23, 2015

feross added a commit that referenced this issue Mar 23, 2015

Significant speed increase / remove jscs linter
Improves performance of standard by 2-4x by:

- remove the need for `npm run which-eslint`
- remove the `child_process.exec` calls and use the node api of eslint
directly
- Remove `jscs` linter

Fixes #43 - speed issues
Fixes #45 - eliminate jscs

Lays the groundwork for #60 - programmatic use
@feross

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2015

This is released as 3.3.0.

@feross feross closed this in e128f94 Mar 26, 2015

feross added a commit that referenced this issue Mar 26, 2015

Significant speed increase / remove jscs linter
Improves performance of standard by 2-4x by:

- remove the need for `npm run which-eslint`
- remove the `child_process.exec` calls and use the node api of eslint
directly
- Remove `jscs` linter

Fixes #43 - speed issues
Fixes #45 - eliminate jscs

Lays the groundwork for #60 - programmatic use

feross added a commit that referenced this issue Mar 26, 2015

use latest eslint
Depending on the latest eslint via git will let us release the next
version of `standard` asap and fix #43, #45, and #60. Once eslint
releases the next version, we can switch back to the npm dep.
@othiym23

This comment has been minimized.

Copy link

commented Mar 26, 2015

🎉 don't forget to approve the Bountysource ticket, if you haven't already!

@feross

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2015

yep - glad it worked :)

@mightyiam

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2015

Entirely awesome.

@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018

brandonocasey added a commit to videojs/tooling that referenced this issue Jun 3, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.