Skip to content

/standard

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dat badge #494

Closed
dcousens opened this issue Apr 22, 2016 · 28 comments

Comments

@dcousens
Copy link
Member

commented Apr 22, 2016

Suddenly, it is huge.
I mean, I don't mind much, but, it definitely looks a bit obnoxious.

dayum

@dcousens dcousens added question meta labels Apr 22, 2016

@feross

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 22, 2016

Hahaha, will look into that
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 22, 2016

Works fine for me:

screen shot 2016-04-21 at 17 20 15
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 22, 2016

I just tried exporting the badge with an explicit size, instead of relying on DPI. Give that page a refresh and let me know if it's better.
@dcousens

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 22, 2016 •
edited

@feross interesting.
Happens for me in both Firefox 45.0.2 and Chromium 50.0.2661.75

edit: @feross still occurs.
edit2: accidental close

@dcousens dcousens closed this Apr 22, 2016

@dcousens dcousens reopened this Apr 22, 2016

@feross

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 22, 2016

Try again?

feross added a commit that referenced this issue Apr 22, 2016

@feross
attempt fix to huge svg badge on linux (#494)
Loading status checks…
31254b6
@dcousens

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 22, 2016

@feross it happens even when directly linked to the file: https://camo.githubusercontent.com/e06d9d72eecca61c1ba39fdf19868f70fcb3a9b3/68747470733a2f2f63646e2e7261776769742e636f6d2f6665726f73732f7374616e646172642f6d61737465722f62616467652e737667
@dcousens

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 22, 2016 •
edited

@feross still unchanged, RE 31254b6

feross added a commit that referenced this issue Apr 22, 2016

@feross
Revert "attempt fix to huge svg badge on linux (#494)" 
This reverts commit 31254b6.
47aeb82
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 22, 2016

Fixed

@feross feross closed this Apr 22, 2016

@dcousens

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 22, 2016 •
edited

Not fixed here...
hmm

@dcousens dcousens reopened this Apr 22, 2016

@feross

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 22, 2016

I don't know what to tell you. Works for me on ubuntu.

screen shot 2016-04-21 at 17 54 30
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 22, 2016

I reverted the badge change from 6 days ago, so if it worked for you before, then it should be back to that old state again. Badges used to look fine with your setup right?
@dcousens

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 22, 2016 •
edited

@feross that they did, but I have no idea why this is different now.

This occurs on both a Macbook Air (OSX) and an Arch Linux machine.
Using:

  • Chromium
  • Google Chrome
  • Firefox
@dcousens

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 22, 2016 •
edited

ping @fanatid, @jprichardson, @calvinmetcalf, any of you three experiencing this?

edit: And just to rule out geolocality ping @dannyshaw
@fanatid

This comment has been minimized.

Sign in to view
Copy link

commented Apr 22, 2016

@dcousens works fine for me
screenshot at 2016-04-22 07 12 49
Fedora 23, 64 bit
Firefox 45.0.1
Chrome 50.0.2661.49
@dcousens

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 22, 2016

@feross @fanatid this is odd. I have the same issue on my Android device(s) using 4G.
I guess this must be a geolocality issue?

1mgo7ho
bncnmvx
@fanatid

This comment has been minimized.

Sign in to view
Copy link

commented Apr 22, 2016

@dcousens looks like not geolocality issue, right now on npmjs (on github all looks good):
screenshot at 2016-04-22 12 30 42
@dcousens

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 22, 2016

Ha! I knew I wasn't crazy.
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 22, 2016

Weird. Any ideas?
@jprichardson

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 23, 2016

Holy big badge batman!

screen shot 2016-04-22 at 10 01 00 pm
@bencevans

This comment has been minimized.

Sign in to view
Copy link

commented Apr 23, 2016

Same here, Ubuntu 15.10, Google Chrome Version 49.0.2623.87 (64-bit).

selection_012

Wondered if it was just stuck in GitHub's CDN Cache as when rendered on GitHub it's coming from https://cloud.githubusercontent.com/assets/638535/14762425/c2d82f32-0971-11e6-8f03-0e78fc4e9545.png but the same is happening on npm which loads the badge from https://cdn.rawgit.com/feross/standard/master/badge.svg

Opening https://cdn.rawgit.com/feross/standard/master/badge.svg in the browser I'm getting...

https --cdn rawgit com-feross-standard-master-badge svg - google chrome_013
@jprichardson

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 23, 2016

Come on @feross... be honest now, this was your attempt at having Standard take over the world?? 😉
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 24, 2016

@jprichardson Yeah, you caught me! 😨

For real, though. This is so odd. Anyone have any ideas?
@feross feross referenced this issue Apr 24, 2016
Closed
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 24, 2016

The svg file returned by rawgit is different from the one currently in our repo. I opened an issue to ask them if they can delete the cached version: rgrove/rawgit#111
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 24, 2016

This is fixed now!

@feross feross closed this Apr 24, 2016

@dcousens dcousens reopened this Apr 24, 2016

@dcousens

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 24, 2016 •
edited

Hate to be a pain... but this is still happening [for me].
And I cleared all my caches.

I have no idea why.
@jprichardson

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 25, 2016

It's fixed for me.
@dcousens

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Apr 26, 2016

Maybe they didn't flush the Australian CDN? :shrug:
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

commented May 2, 2016

I got them to purge the cache once more: rgrove/rawgit#111 (comment)

At this point, there's nothing else we can do.

@feross feross closed this May 2, 2016

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
meta question
Milestone
No milestone
5 participants
@dcousens @feross @fanatid @jprichardson @bencevans
You can’t perform that action at this time.