Skip to content

/standard

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standard exiting non-zero on failure in 0.10 #529

Closed
searls opened this issue May 24, 2016 · 2 comments

Comments

@searls
Copy link

commented May 24, 2016

Take a look at this build to see the issue:

https://travis-ci.org/testdouble/test-smells/builds/131741480

Standard clearly had a failure on all three VMs, but must have exited code 0 erroneously on Node v0.10.36. To reproduce, you can just clone the repo and check out that commit.
@feross feross referenced this issue May 26, 2016
Merged
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

commented May 26, 2016

We dropped 0.10 support in standard-engine.

PR to add it back: standard/standard-engine#109
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

commented May 26, 2016

Just released standard-engine 4.0.3. If you reinstall standard it should work again.

@feross feross closed this May 26, 2016

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@searls @feross
You can’t perform that action at this time.