Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upQuestion about allowed function call #530
Comments
This comment has been minimized.
This comment has been minimized.
window.addEventListener
('keydown', myKeydownHandler, false)seems definitely off. All the other ones feel like a bit of a smell to me, but sure - there's probably a valid use case for them |
This comment has been minimized.
This comment has been minimized.
|
I use the others on occasion, but parens on a new line seems bad |
This comment has been minimized.
This comment has been minimized.
|
Agreed. The paren should not go on a separate line. I don't think there is an eslint rule for this. Does someone want to volunteer to open an issue / send a PR to eslint to add this? |
This comment has been minimized.
This comment has been minimized.
|
Agreed, that is incredibly confusing. |
feross
added
the
blocked
label
Jul 12, 2016
feross
closed this
in
standard/eslint-config-standard@f419de5
Aug 19, 2016
This comment has been minimized.
This comment has been minimized.
|
This will be fixed in standard v8! I just replaced the deprecated "no-spaced-func" rule with "func-call-spacing" which checks for this! |
feross
removed
the
blocked
label
Aug 19, 2016
lock
bot
locked as resolved and limited conversation to collaborators
May 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
LinusU commentedMay 25, 2016
Should this style of function calling be allowed? I haven't seen it anywhere in the wild until a coworker tried merging it to one of our repos today...
I feel that the allowed options should be
,
and possibly
as this is what I've seen being used by the community the most.