Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upThis was a good initiative but has turned to become too restrictive #533
Comments
This comment has been minimized.
This comment has been minimized.
|
@gsklee Can you share a code example that used to pass but is now failing? We lock the ESLint configuration version to exact versions so that But we have a looser ESLint version range ( If you share what broke for you, we can issue a patch update that locks the faulty dependency. |
This comment has been minimized.
This comment has been minimized.
|
I've experienced this before. It's foo={ a } that's not allowed anymore, On Mon, May 30, 2016, 12:55 PM Feross Aboukhadijeh notifications@github.com
|
This comment has been minimized.
This comment has been minimized.
|
Exactly what @rstacruz has mentioned. |
This comment has been minimized.
This comment has been minimized.
|
@gsklee I just did a little investigating and this was actually part of In general, we don't add new rules that disrupt lots of users, even in a new major version. We have a test suite that lets us assess the impact of a change on the ecosystem of users and this didn't affect any of the repos we test on. One of the tenets of Sorry that you're experiencing new errors after upgrading. I recommend downgrading to standard v5.x and only upgrading if/when you're ready to change your code. In the future, you can participate in discussions before a release if you're interested. Cheers! |
gsklee commentedMay 30, 2016
•
edited
Our project went from 0 to 900+ errors overnight because somehow the updated rules or linter decided to suddenly begin issuing warnings against whitespaces around JSX attribute equal signs. I was a big pusher for the standard within my organization, but with an ever-changing ruleset like this, I honestly am no longer sure how can I continue to sell or advocate for your initiative.