Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring --format back #540

Closed
sheerun opened this Issue Jun 3, 2016 · 7 comments

Comments

4 participants
@sheerun
Copy link

sheerun commented Jun 3, 2016

Isn't auto-formatting a free feature with new eslint? Could you bring it back to standard?

@rstacruz

This comment has been minimized.

Copy link
Member

rstacruz commented Jun 3, 2016

npmjs.com/package/standard-format

It was a very huge dependency which was wasteful when not needed. You can
still install it separately.

On Fri, Jun 3, 2016, 10:21 PM Adam Stankiewicz notifications@github.com
wrote:

Isn't auto-formatting a free feature with new eslint? Could you bring it
back to standard?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#540, or mute the thread
https://github.com/notifications/unsubscribe/AAEikbI79Oqy9_RfeboJf-wSv5iitkkcks5qIDhkgaJpZM4ItlFA
.

@sheerun

This comment has been minimized.

Copy link
Author

sheerun commented Jun 3, 2016

You already depend on eslint, and nowadays it has --fix flag that does exactly it. No need for extra dependencies.

@rstacruz

This comment has been minimized.

Copy link
Member

rstacruz commented Jun 3, 2016

ohh... that's a very interesting development. @feross?

@sheerun

This comment has been minimized.

Copy link
Author

sheerun commented Jun 3, 2016

Plesae also consider renaming it to "fix". eslint and xo already use this convention.

@Flet

This comment has been minimized.

Copy link
Member

Flet commented Jun 3, 2016

There is an issue open on standard-engine proposing that the eslint fix flag be added into it.. which could trickle down into standard

standard/standard-engine#107

@feross

This comment has been minimized.

Copy link
Member

feross commented Jun 3, 2016

Yep, I'm cool with this. The right place to add it is standard-engine.

@feross

This comment has been minimized.

Copy link
Member

feross commented Jul 12, 2016

Sent a PR to standard-engine to implement a --fix command line flag: standard/standard-engine#107

This will be included in the next major version release of standard.

@feross feross closed this Jul 12, 2016

@feross feross referenced this issue Jul 12, 2016

Closed

Release proposal: standard v8 #564

16 of 16 tasks complete

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.