Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upMaybe consider disallowing `jsx` extension? #585
Comments
This comment has been minimized.
This comment has been minimized.
|
Seems like decent reasoning, but I don't feel this is super important. I do know that We could consider only detecting .js files by default, instead .js and .jsx like we do now. This would slightly discourage usage of .jsx. People who use .jsx would have to change their command to Do other contributors have thoughts? |
feross
added
the
question
label
Aug 11, 2016
feross
added
the
need more info
label
Aug 19, 2016
This comment has been minimized.
This comment has been minimized.
|
I don't really see the benefit of stopping automatically checking .jsx files. It'll just trip up some users who use that extension. If you don't want to use .jsx, you can just use .js and standard works fine. And as mentioned before, we shouldn't actively prevent the usage of a certain extensions, IMO. |
capaj commentedAug 11, 2016
I have read beautiful reasoning as to why it is not the best practice to name files with JSX
.jsx, but instead.js: airbnb/javascript#985 (comment)In my future projects I would prefer if I would not see
.jsxfiles- do you think this is a rule standard could merge if I opened a PR for it? I guess there isn't an eslint rule for that, but maybe we could create one? Or maybe just use a simple glob expression?